Action Mailer - It has to be easier?


  class FormMailer < ActionMailer::Base

  def contact_us(params)
    from params[:email]
    recipients params[:to]
    subject params[:subject]
    body :params => params
  end

  def help_request(params)
    from params[:email]
    recipients params[:to]
    subject params[:subject]
    body :params => params
  end

  def service(params)
    from params[:email]
    recipients params[:to]
    subject params[:subject]
    body :params => params
  end

  def customer_care(params)
    from params[:email]
    recipients params[:to]
    subject params[:subject]
    body :params => params
  end

  def tellafriend(params)
    from params[:from_email]
    recipients params[:friend_email]
    headers 'Disposition-Notification-To' => params[:from_email] if params[:notify] == 'yes'
    subject params[:subject]
    body :params => params
  end

  # snip... 20 more
end

  Here is a FormMailer that I have.  As you know, ActionMailer is a Model not a controller.  But I have yet to figure out how to reduce this to one method instead of 20...
  2008-03-01T19:19:54+00:00
  246
  Ruby
  action-mailer-it-has-to-be-easier
  4
  Action Mailer - It has to be easier?
  
  2009-11-13T18:38:04+00:00
  49
  
    
      class FormMailer < ActionMailer::Base
  def send_email(params)
    from params[:email]
    recipients params[:to]
    subject params[:subject]
    body :params => params
  end

  def customer_care(params) send_email(params); end
end
      246
      You can probably make this even more dry with alias_method, but I'm not sure how that would interact with the magic ActionMailer methods.
      2008-03-02T02:08:12+00:00
      3590
      Ruby
      3
      1
      On Action Mailer - It has to be easier?
      
      Emmett
      www.justin.tv
    
    
      class FormMailer < ActionMailer::Base

  %w{contact_us help_request service customer_care}.each do |method_name|

    define_method(method_name) do |params|
      from params[:email]
      recipients params[:to]
      subject params[:subject]
      body :params => params
    end

  end

end
      246
      You could try some meta-programming.  This way your list of method names is nice and centralized.
      2008-03-02T04:00:31+00:00
      3594
      Ruby
      4
      2
      On Action Mailer - It has to be easier?
      178
      Barry Hess
      http://blog.bjhess.com
    
    
      def method_missing(m, *args)      
  unless m.to_s[0, 8] == 'deliver_'
    from params[:email]
    recipients params[:to]
    subject params[:subject]
    body :params => params
  end
end
      246
      Haven't had much sleep and therefore my mind might have produced some crappy idea, but maybe might be able to elaborate a little bit more on it. What I would suggest is using the method_missing functionality in order to create the method. This might interfere with the parents implementation for creating the "deliver_" prefixed methods. But I am not that into metaprogramming. Moreover, one might wanna add some check if the rendering of the template works.
      2008-03-02T20:36:29+00:00
      3619
      Ruby
      0
      0
      On Action Mailer - It has to be easier?
      212
      namxam
      http://max.jungeelite.de/
    
    
      class FormMailer < ActionMailer::Base
  before_deliver :prep_email

  def contact_us(params)
  end

  def help_request(params)
  end

  def service(params)
  end

  def customer_care(params)
  end

  def tellafriend(params)
    headers 'Disposition-Notification-To' => params[:from_email] if params[:notify] == 'yes'
  end

  protected
  def prep_email
    from params[:from_email]
    recipients params[:friend_email]
    subject params[:subject]
    body :params => params
  end
end

      246
      This seems like a job for filters.  Unfortunately, ActionMailer isn't ActionController, and doesn't have them.  But if you're feeling lucky, there is a plugin.  

http://www.pathf.com/blogs/2009/01/actionmailer-callbacks-in-the-spirit-of-actioncontroller-filters/

I guess you'd end up with something like:
      2009-11-13T18:37:44+00:00
      359685
      Ruby
      0
      0
      On Action Mailer - It has to be easier?
      
      Bryce
      http://twitter.com/darth_schmoo