Pastable version of Looking for comments on style and clearness

<div style="overflow:auto;border:solid 1px #ccc;background:#000;color:#F8F8F8">
 <div class="section">
 
 <pre style="float:left;margin:0 10px;border-right:0;color:#666;">1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86</pre>
 <pre class="sunburst"># Ruby Quiz 2 - Scalable LCD Monitor 
# Gerard (smeevil) de Brieder - Govannon - 2008-06-12

class Lcd
 attr_accessor :line
 
 def initialize(numbers,scale)
 
 total_lines=5+((scale-1)*2) #compute the total output lines needed for scale (minimal 5)
 
 @lines=Array.new # build and reserve array spaces for the output lines
 total_lines.times do
 @lines &lt;&lt; &quot;&quot;
 end
 
 @scale=scale
 numbers.scan(/./).each { |number| number_builder(get_number_sequence(number)) } 
 end

def get_number_sequence(number) #converts a given number to a sequence used by number_builder
 
 case number
 when &quot;0&quot; then @sequence=&quot;24142&quot;
 when &quot;1&quot; then @sequence=&quot;15151&quot;
 when &quot;2&quot; then @sequence=&quot;25232&quot;
 when &quot;3&quot; then @sequence=&quot;25252&quot;
 when &quot;4&quot; then @sequence=&quot;14251&quot;
 when &quot;5&quot; then @sequence=&quot;23252&quot;
 when &quot;6&quot; then @sequence=&quot;23242&quot;
 when &quot;7&quot; then @sequence=&quot;25151&quot;
 when &quot;8&quot; then @sequence=&quot;24242&quot;
 when &quot;9&quot; then @sequence=&quot;24252&quot;
 end
 
 @result=''
 
 @sequence.scan(/./).each_with_index { |seq,index|
 @result+=seq
 unless index%2==0 #add extra chars for the bigger scale lcd
 (@scale-1).times{ @result+=seq }
 end
 }

return @result 
 end
 
 def number_builder(sequence) #creates an lcd number from a given sequence and adds it to the lines array
 
 dashes=&quot;&quot;
 spaces=&quot;&quot;
 @scale.times do #define spaces and vertical dash size for scale
 dashes+=&quot;-&quot;
 spaces+=&quot; &quot;
 end
 
 sequence.scan(/./).each_with_index do |s,i| #create the lcd number 
 case s
 when &quot;1&quot; then @lines[i]+=&quot; #{spaces} &quot;
 when &quot;2&quot; then @lines[i]+=&quot; #{dashes} &quot;
 when &quot;3&quot; then @lines[i]+=&quot;|#{spaces} &quot;
 when &quot;4&quot; then @lines[i]+=&quot;|#{spaces}| &quot;
 when &quot;5&quot; then @lines[i]+=&quot; #{spaces}| &quot; 
 end
 end
 end
 
 def print
 @lines.each { |line| puts line unless line==''}
 end
end

def check_arguments
 
 if ARGV[0]=~/^\d+$/ 
 @scale=&quot;1&quot;
 @number=ARGV[0]
 end

if ARGV[0]=~/^-s$/ 
 @scale=ARGV[1]
 @number=ARGV[2]
 end

@scale &amp;&amp; @number &amp;&amp; @number=~/^\d+$/ ? true : false #are all arguments accepted ?
end

</pre>
 </div>
 </div>

<div style="overflow:auto;border:solid 1px #ccc;background:#000;color:#F8F8F8">
 <div class="section">
 ########### MAIN ##############
 <pre style="float:left;margin:0 10px;border-right:0;color:#666;">1
2
3
4
5
6
7
8
9
10
11
12
13</pre>
 <pre class="sunburst">
if check_arguments
 @lcd=Lcd.new(@number,@scale.to_i)
 @lcd.print
else
 print &quot;
 LCD DISPLAY
 ===========
 usage : quiz2 -s &lt;scale&gt; &lt;number&gt;
 example : quiz2 -s 2 12345
 -s &lt;scale&gt; -s is optional
 &quot;
end
</pre>
 </div>
 </div>

Refactor :my => 'code'

Recent

Popular

Pastable version of Looking for comments on style and clearness