switch statement a good idea?


  	public function setClass($class){
		switch($class){
			case "050":
			case "055":
			case "060":
			case "065":
			case "070":
			case "077":
			case "085":
			case "092":
			case "100":
			case "110":
			case "125":
			case "150":
			case "175":
			case "200":
			case "250":
			case "300":
				$this->class = $class;
				break;
			default:
				print "invalid class!";
				return false;
		}
		
		return true;
	}
  I'm making a switch statement to verify some input. It's got all of the possible values (not likely to change much) and if the passed item isn't one of these values it prints an error. Is this a good idea? Is there a better way? Thanks!
  2008-08-12T18:19:17+00:00
  431
  PHP
  switch-statement-a-good-idea
  5
  switch statement a good idea?
  
  2008-10-09T02:54:21+00:00
  905
  
    
      $CLASSES_CONSTANT = array("050","055","060");

function setClass($class)
{
    if(in_array($class, $CLASSES_CONSTANT))
    {  
      $this->class = $class;
    }  
    else
    {
      print "invalid class!";
    }
}      
      431
      It's a setter, so there's not really a compelling reason to return anything.  There's a few other fundamental issues with this code, but here's a refactoring to maybe help clean it up and make it easier to add/remove classes in the near future without having to touch the function again.  

Add the $CLASSES_CONSTANT to a global environment file and also rename it if need be, this way you can do the add/remove in 1 spot.
      2008-08-12T19:04:21+00:00
      14899
      PHP
      5
      2
      On switch statement a good idea?
      
      Corey Grusden
      http://blog.divergentsoftware.com
    
    
      public function setClass($class){
	$my_array = array("050", "055", "060", "065", "070", "077", "085", "092", "100", "110", "125", "150", "175", "200", "250", "300");
        if (in_array($class, $my_array)){
		$this->class = $class;
		break;
	} else {
		print "invalid class!";
		return false;
	}
	return true;
}
      431
      I would use the in_array() function to avoid the long listing and repeated typing:
      2008-08-12T19:06:56+00:00
      14900
      PHP
      5
      1
      On switch statement a good idea?
      
      Marco Kranenburg
      
    
    
      
      431
      Hrm... not a bad idea. Thanks!
      2008-08-12T19:45:46+00:00
      14908
      PHP
      0
      0
      On switch statement a good idea?
      905
      cmcculloh
      http://www.chomperstomp.com
    
    
      
      431
      Although I think your code is much faster that using in_array().
      2008-09-11T03:00:37+00:00
      16990
      PHP
      0
      0
      On switch statement a good idea?
      
      Mario Estrada
      http://mario.ravica.com.ec
    
    
      //somwhere in your class
const CLASSES = {021,078,192,210,240};


//constructor

function __construct($class){
    $this->setClass($class);
}


function setClass($class){
      if($this->isValidClass($class)
          $this->class = $class;
          return true; 
      else
         return false;

}


private function isValidClass($class){
     return in_array($class,SELF::CLASSES);

}
      431
      Well since you are using 'this' you must already be a class so you would have to use a const. Depending on your use case maybe you could even do a check at the constructor to see if it a valid class...here are a few ideas of what I would do to allow the most flexiblity and reusability.
      2008-10-09T02:54:20+00:00
      54584
      PHP
      0
      0
      On switch statement a good idea?
      
      Mark