Cleaner Ruby


  class RSExp

	def equate(xp)
		(xp + 300 * (2 ** (xp.to_f / 7))).floor
	end

	def level_to_xp(level)
		xp = 0.0

		(1...level).each do |lvl|
			xp += equate(lvl)
		end

		(xp / 4).floor
	end

	def xp_to_level(xp)
		level = 1

		while level_to_xp(level) < xp
			level += 1
		end

		level
	end

end

rs = RSExp.new

(1...100).each do |lvl|
	puts("level #{lvl}: #{rs.level_to_xp(lvl)}")
end
  Noob to Ruby here. Any way to make this cleaner?
  2008-09-20T03:43:30+00:00
  498
  Ruby
  cleaner-ruby
  5
  Cleaner Ruby
  
  2008-09-22T19:05:59+00:00
  1027
  
    
      # Duplicated post, please help to delete
      498
      
      2008-09-20T23:34:59+00:00
      27707
      Ruby
      1
      1
      On Cleaner Ruby
      856
      Tien Dung
      http://codemonkeycode.blogspot.com/
    
    
      def equate(level)
  (level + 300 * (2 ** (level / 7.0))).floor
end

x = 0
(1...100).each do |level|
  puts("level #{level}: #{(x/4).floor}")
  x = x + equate(level)
end

      498
      Man, you made your code over complicated and ugly.

* Why you use class as a namespace?
* Why you create a function called xp_to_level and don't use it in your program?
* Why you don't reuse computation result from previous step?
* Why you name a function that no one can understand what does it mean without any comment? (what does xp stand for).

Here is an equivalent program that is faster, clearer and shorter.
      2008-09-20T23:57:43+00:00
      27750
      Ruby
      0
      0
      On Cleaner Ruby
      856
      Tien Dung
      http://codemonkeycode.blogspot.com/
    
    
      class RandomClassName < Struct.new(:level)
  RANDOMLY_CHOSEN_CONSTANT_1 = 300
  RANDOMLY_CHOSEN_CONSTANT_2 = 7.0
  
  def some_kind_of_conversion_from_level
    (calculation_method_just_because_by_level / 4.0).floor
  end
  
  def to_s
    "level #{level}: #{some_kind_of_conversion_from_level}"
  end
  
  protected
    def calculation_method_just_because_by_level
      1.enum_for(:upto, level).inject do |randomly_chosen_name,name_that_describes_what_this_is|
        randomly_chosen_name + calculation_method_just_because(name_that_describes_what_this_is)
      end
    end    
  
    def calculation_method_just_because(randomly_chosen_variable)
      interesting_calcuation = (randomly_chosen_variable / RANDOMLY_CHOSEN_CONSTANT_2) ** 2
      (randomly_chosen_variable + RANDOMLY_CHOSEN_CONSTANT_1 * interesting_calcuation).floor
    end
end

100.times do |level|
  puts RandomClassName.new(level + 1)
end
      498
      
      2008-09-22T01:45:00+00:00
      28395
      Ruby
      3
      3
      On Cleaner Ruby
      938
      Adam
      
    
    
      
      498
      @Adam: cool refactoring :D
      2008-09-22T01:53:58+00:00
      28396
      Ruby
      0
      0
      On Cleaner Ruby
      856
      Tien Dung
      http://codemonkeycode.blogspot.com/
    
    
        .-´¯¯¯`-.
,´          `.
|             \
|              \
\           _  \
,\  _    ,´¯,/¯)\
( q \ \,´ ,´ ,´¯)
 `._,)     -´,-´)
   \/         ,´/
    )        / /
   /       ,´-´
      498
      Oh lawd
      2008-09-22T19:05:58+00:00
      28659
      Ruby
      0
      0
      On Cleaner Ruby
      1027
      pootcode