class Item
def raw_tag_list; "one, two, three, four, five"; end
def public_tags; [<#Tag name=two>, <#Tag name=five>, <#Tag name=one>, <#Tag name=four>, <#Tag name=three>]; end
def tags
return Array.new if raw_tag_list.nil?
# Get the raw tag list, split, squish (removed whitespace), and add each to raw_tag_array
# Make sure we skip if the array already has that tag name (remove any duplicates that occur)
raw_tag_array = Array.new
raw_tag_list.split(',').each do |raw_tag|
next if raw_tag_array.include?(raw_tag.squish)
raw_tag_array << raw_tag.squish
end
tags = Array.new
# grab all the tag objects
tags_out_of_order = public_tags
if tags_out_of_order.size > 0
# resort them to match raw_tag_list order
raw_tag_array.each do |tag_name|
tag = tags_out_of_order.select { |tag| tag.name == tag_name }
tags << tag
end
# at this point, we have an array, with arrays of object [[tag], [tag], [tag]]
# use compact to remove any nil objects, and flatten to convert it to [tag, tag, tag]
tags = tags.compact.flatten
end
tags
end
end
Is there a faster way to do this? I need to sort an array of tags according to the order of tags in a string. At the moment, I make the array then select as go through. But this is slow. Is there a fancy ruby alternative?
2009-03-30T22:48:23+00:00
807
Ruby
tag-ordering-code
12
Tag ordering code
2009-04-01T17:47:43+00:00
1425
class Tag
def initialize name
@name = name
end
def self.parse string
string.split(',').map { |tag| Tag.new(tag.strip) }
end
end
params = { :tags => 'foo,bar, some more bar, whoop' }
p Tag.parse(params[:tags])
# => [#<Tag:0x27a88 @name="foo">, #<Tag:0x27a60 @name="bar">, #<Tag:0x27a38 @name="some more bar">, #<Tag:0x27a10 @name="whoop">]
807
I dont know exactly what your trying to accomplish, but its wrong :p
2009-03-30T23:40:38+00:00
153675
Ruby
0
0
On Tag ordering code
634
Tj Holowaychuk
http://vision-media.ca
class Item
def raw_tag_list; "one, two, three, four, five"; end
def public_tags; [<#Tag name=two>, <#Tag name=five>, <#Tag name=one>, <#Tag name=four>, <#Tag name=three>]; end
def tags
return Array.new if raw_tag_list.nil?
# Get the raw tag list, split, squish (removed whitespace), and add each to raw_tag_array
# Make sure we skip if the array already has that tag name (remove any duplicates that occur)
raw_tag_array = Array.new
raw_tag_list.split(',').each do |raw_tag|
next if raw_tag_array.include?(raw_tag.squish)
raw_tag_array << raw_tag.squish
end
tags = Array.new
# grab all the tag objects
tags_out_of_order = public_tags
if tags_out_of_order.size > 0
# resort them to match raw_tag_list order
tags = tags_out_of_order.sort { |a, b| raw_tag_array.index(a.name).to_i <=> raw_tag_array.index(b.name).to_i } ### <-----
end
tags
end
end
807
Thanks for trying. I ended up going with the following or now. Note the sort replacing 5 lines. The idea is to take an unordered sql query result from Rails, and order it according to a comma separated string.
2009-03-30T23:46:16+00:00
153676
Ruby
0
0
On Tag ordering code
1425
k776
http://k776.blogspot.com
class Item
def raw_tag_list; "one, two, three, four, five"; end
def public_tags; [<#Tag name=two>, <#Tag name=five>, <#Tag name=one>, <#Tag name=four>, <#Tag name=three>]; end
def tags
return Array.new if raw_tag_list.blank?
raw_tag_array = raw_tag_list.squish.split(/\s?,\s?/).uniq
tags = public_tags
tags.sort! { |a, b| raw_tag_array.index(a.name).to_i <=> raw_tag_array.index(b.name).to_i } if tags.size > 0
tags
end
end
807
Got it down to this. Can you do better?
2009-03-31T06:41:01+00:00
153714
Ruby
0
0
On Tag ordering code
1425
k776
http://k776.blogspot.com
require 'Linguistics'
class Tag < Struct.new(:name)
NUMBERS = (0..100).inject(Hash.new(1 / 0.0)) do |hash,number|
hash.merge(Linguistics::EN.numwords(number) => number)
end
def to_i
NUMBERS[name]
end
def <=>(tag)
to_i <=> tag.to_i
end
end
class Item
def public_tags
[ Tag.new('eight'), Tag.new('five'), Tag.new('ten'), Tag.new('foo'), Tag.new('one') ]
end
def tags
public_tags.sort
end
end
807
2009-04-01T05:07:17+00:00
153801
Ruby
0
0
On Tag ordering code
938
Adam
require 'Linguistics'
Tag = Struct.new(:name).class_eval do
NUMBERS = (0..100).inject(Hash.new(1 / 0.0)) do |hash,number|
hash.merge(Linguistics::EN.numwords(number) => number)
end
def to_i
NUMBERS[name]
end
def <=>(tag)
to_i <=> tag.to_i
end
self
end
class Item
def public_tags
[ Tag.new('eight'), Tag.new('five'), Tag.new('ten'), Tag.new('foo'), Tag.new('one') ]
end
def tags
public_tags.sort
end
end
807
Refactored to eliminate the inheritance because Tj doesn't like it extra classes. ;)
2009-04-01T15:39:21+00:00
153844
Ruby
0
0
On Tag ordering code
938
Adam