1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56
<div id="main"> <?php if($user == ""){ firehtml($_GET['f']); } else { //homepage functions for logged in users if($_GET['f'] ==""){ $homepage = new homepage; $homepage->clear(); $homepage->pulluser(); $homepage->buildhomepage(); $homepage->dumphomepage(); } else if($_GET['f'] == "p") { //project functions $projectserv = new sql_query; $projectserv->projectserv(); $projectserv->projectdump(); $projects = $projectserv->projectarray; $projectl = $projectserv->projectlink; $i = 1; echo "<div id=\"hplcontainer\">"; while($i <= sizeof($projects)){ //$i--; if($projectl[$i] != ""){ echo "<div id=\"homepagelist\">"; echo "<a href =\"?f=e&e=" .$projectl[$i] . "\">" . $projects[$i] . "</a>"; echo "</div>"; $i++; } else { echo "<div id=\"homepagelist\">"; echo $projects[$i]; echo "</div>"; $i++; } } echo "</div>"; } else if($_GET['f'] == "np"){ $form = new project(); $form->projectform(); } } ?> </div>
Refactorings
No refactoring yet !
macournoyer
October 22, 2007, October 22, 2007 17:44, permalink
hey thelittleninja, I doubt someone would want to refactor all this. Think about submitting a much tinier piece of code, or only a part of the page you find particularly ugly.
Lokycss
October 27, 2007, October 27, 2007 20:32, permalink
Sorry, my level english is very poor and so i'm not sure if understood the problem. Whatever you want is split the last source code on many files, and then, load in fuction of the parameter 'p' on the $_GET variable?
This is the homepage of my site codera, ideally each different section (seperated by the $_GET['f'] variable) should be on an include, or even better a different page so that I can link to the pysical pages and not have them all on one page, as is the case at the moment